Sandro Bonazzola has posted comments on this change. Change subject: core: Alert if priorities were overriden ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29180/1/src/otopi/context.py File src/otopi/context.py: Line 389: methods[i+1]['method'], Line 390: methods[i+1]['priority'], Line 391: m['method'], Line 392: m['priority'], Line 393: ) > but this is intentional, the priority is only a hint the before/after are s so maybe raising a runtime error is a bit too much, but a warning will be appreciated since it seems we have some stages relying on high priority to be scheduled before low priority and this is not guaranteed. With the warning we can see where the assumption is broken and add relevant stages for using before/after. It will help us with debugging. Line 394: ) Line 395: self._sequence = sequence Line 396: Line 397: def runSequence(self): -- To view, visit http://gerrit.ovirt.org/29180 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5610d172ee6dd8765beefb8b27a9a94395b232e2 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
