Alon Bar-Lev has posted comments on this change. Change subject: core: Alert if priorities were overriden ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29180/1/src/otopi/context.py File src/otopi/context.py: Line 389: methods[i+1]['method'], Line 390: methods[i+1]['priority'], Line 391: m['method'], Line 392: m['priority'], Line 393: ) > so maybe raising a runtime error is a bit too much, but a warning will be a we can print whatever warning we like using the early debug. but again, I do not think this is an error at all nor warning. it is intentional to have several levels of hints, if you use before/after you take over of that hint. Line 394: ) Line 395: self._sequence = sequence Line 396: Line 397: def runSequence(self): -- To view, visit http://gerrit.ovirt.org/29180 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5610d172ee6dd8765beefb8b27a9a94395b232e2 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
