Liron Aravot has posted comments on this change. Change subject: core: Use configuration for Import Storage Domain ......................................................................
Patch Set 8: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/29020/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java: Line 128: "The meta data of the Storage Domain might still indicate that it is attached to a different Storage Pool.", Line 129: getParameters().getStorageDomainId(), storagePoolId); Line 130: } Line 131: } else { Line 132: log.errorFormat("Attcah Storage domain is not supported for this Data Center version."); let's just throw an exception here, no need to run attach which is a spm verb just to have it throw exception. Line 133: } Line 134: } Line 135: } Line 136: http://gerrit.ovirt.org/#/c/29020/8/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java: Line 738: VDS_GROUP_CPU_IS_NOT_UPDATABLE(ErrorType.CONFLICT), Line 739: CPU_TYPE_UNSUPPORTED_IN_THIS_CLUSTER_VERSION(ErrorType.CONFLICT), Line 740: USER_FAILED_TO_AUTHENTICATE_ACCOUNT_IS_LOCKED_OR_DISABLED(ErrorType.NO_AUTHENTICATION), Line 741: ACTION_TYPE_FAILED_CANNOT_REMOVE_BUILTIN_GROUP_EVERYONE(ErrorType.CONFLICT), Line 742: ACTION_TYPE_FAILED_IMPORT_DATA_DOMAIN_IS_NOT_SUPPORTED(ErrorType.NOT_SUPPORTED), where is that message used? Line 743: VM_CANNOT_RUN_ONCE_WITH_ILLEGAL_SYSPREP_PARAM(ErrorType.BAD_PARAMETERS), Line 744: MOVE_VM_CLUSTER_MISSING_NETWORK(ErrorType.CONFLICT), Line 745: ACTION_TYPE_FAILED_STORAGE_POOL_WITH_DEFAULT_VDS_GROUP_CANNOT_BE_LOCALFS(ErrorType.CONFLICT), Line 746: DEFAULT_CLUSTER_CANNOT_BE_ON_LOCALFS(ErrorType.CONFLICT), -- To view, visit http://gerrit.ovirt.org/29020 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b1824320223c915b97e0ea487abec285cea31e5 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
