Ravi Nori has posted comments on this change. Change subject: engine : Command Executor should persist command before submitting to threadpool ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29219/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java: Line 111: Line 112: public Future<VdcReturnValueBase> executeAsyncCommand(final VdcActionType actionType, Line 113: final VdcActionParametersBase parameters) { Line 114: final CommandBase<?> command = CommandsFactory.createCommand(actionType, parameters); Line 115: command.persistCommand(command.getParameters().getParentCommand(), true); > what happens if the task is rejected on the next line, the command will sta Hi Arik I am not sure I understand your comment. Here is how I tested this I submitted 500 child commands from a parent command with a thread pool size of 10, 500 rows are inserted into the database and the jobs are queued in the ExecutorService's internal queue. As threads become available the commands are executed. When is a command rejected by the executor service? The restart scenario has also been handled. Line 116: return executor.submit(new Callable<VdcReturnValueBase>() { Line 117: Line 118: @Override Line 119: public VdcReturnValueBase call() throws Exception { -- To view, visit http://gerrit.ovirt.org/29219 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d510836dc822a95198dc1db4a4f74206466f0c9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
