Arik Hadas has posted comments on this change. Change subject: engine : Command Executor should persist command before submitting to threadpool ......................................................................
Patch Set 1: >I know that's subjective because it's a design decision but I would really >like not to submit the task from the caller thread but to persist it into a DB >and to have a background job that retrieves the commands from the DB and >submit the tasks ok, on second look I don't agree with my previous comment :) the DB shouldn't be a bus between threads. I would like to have a mechanism such as the one we use in AutoStartVmsRunner - where the caller thread "submit" the task for the job and forget about it, in that stage the caller thread will persist it into the DB. on startup, the job retrieves all the command from the DB (in AutoStartVmsRunner we get all the VMs which are down with error code from the DB as initial data n startup) -- To view, visit http://gerrit.ovirt.org/29219 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d510836dc822a95198dc1db4a4f74206466f0c9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
