Allon Mureinik has posted comments on this change. Change subject: core: Moving out IrsProxyData to a separate file. ......................................................................
Patch Set 1: Code-Review-1 (2 comments) +2 on the idea, -1 on changing visibility of variables. Marking -1 to give my inline question visibility - please answer. Assuming this is not a mistake and there's a good reason for doing so, I'll gladly ack the patch. http://gerrit.ovirt.org/#/c/29264/1//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-06-26 14:45:09 +0300 Line 6: Line 7: core: Moving out IrsProxyData to a separate file. Line 8: Line 9: This will make the code of IrsBrokerCommand be more clear, and s/more clear/cleaer/ Line 10: easy to be adjusted, when needed. Line 11: Line 12: Change-Id: Ie0080ebb2443766a884dd9d9a1082b774a61e87b http://gerrit.ovirt.org/#/c/29264/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java: Line 42: Line 43: @Logged(errorLevel = LogLevel.ERROR) Line 44: public abstract class IrsBrokerCommand<P extends IrsBaseVDSCommandParameters> extends BrokerCommandBase<P> { Line 45: private static Map<Guid, IrsProxyData> _irsProxyData = new ConcurrentHashMap<Guid, IrsProxyData>(); Line 46: static final VDSStatus reportingVdsStatus = VDSStatus.Up; Why not keep it private? I could not find any usage in the extracted IrsProxyData. Line 47: Line 48: /** Line 49: * process received domain monitoring information from a given vds if necessary (according to it's status). Line 50: * @param vds -- To view, visit http://gerrit.ovirt.org/29264 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0080ebb2443766a884dd9d9a1082b774a61e87b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
