Yair Zaslavsky has posted comments on this change. Change subject: core: Moving out IrsProxyData to a separate file. ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29264/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java: Line 42: Line 43: @Logged(errorLevel = LogLevel.ERROR) Line 44: public abstract class IrsBrokerCommand<P extends IrsBaseVDSCommandParameters> extends BrokerCommandBase<P> { Line 45: private static Map<Guid, IrsProxyData> _irsProxyData = new ConcurrentHashMap<Guid, IrsProxyData>(); Line 46: static final VDSStatus reportingVdsStatus = VDSStatus.Up; > Why not keep it private? I could not find any usage in the extracted IrsPro actually there is. Eclipse suggested that during the refactor. See around line 151 in that file - .getVdsDao() .getAllForStoragePoolAndStatus(_storagePoolId, IrsBrokerCommand.repo rtingVdsStatus) Line 47: Line 48: /** Line 49: * process received domain monitoring information from a given vds if necessary (according to it's status). Line 50: * @param vds -- To view, visit http://gerrit.ovirt.org/29264 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0080ebb2443766a884dd9d9a1082b774a61e87b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
