Alon Bar-Lev has posted comments on this change. Change subject: aaa: more fixes to command context propgation ......................................................................
Patch Set 2: > Alon, I pfefer copyOnlyEngineContext() :) this is misleading... for example if we add a new variable into context, and this is to be inherited always... the we duplicate more... and if we do copy only engine context then it should be something like: new CommandContext(parentContext.getEngineContext()) no? but I prefer always to inherit, even if currently we do not see any variable that will always be shared. -- To view, visit http://gerrit.ovirt.org/29290 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbf9e0216c83d981d11bb2d8d2a939fd2a279d9d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
