Moti Asayag has posted comments on this change. Change subject: aaa: more fixes to command context propgation ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29290/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 2179: return getBackend().runInternalQuery(type, queryParams, context.getEngineContext()); Line 2180: } Line 2181: Line 2182: protected CommandContext cloneOnlyEngineContext() { Line 2183: return getContext().withoutCompensationContext().withoutExecutionContext().withoutLock(); > Why not? I clone the engineContext :) because you're using "getContext()" which is: public CommandContext getContext() { return context; } there is no cloning in the method. This method only modifies the current context. isn't it ? Line 2184: } -- To view, visit http://gerrit.ovirt.org/29290 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbf9e0216c83d981d11bb2d8d2a939fd2a279d9d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
