Juan Hernandez has posted comments on this change. Change subject: restapi: add network usages field to "add network to data-center" action parameters ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/29447/1//COMMIT_MSG Commit Message: Line 4: Commit: Yevgeny Zaspitsky <[email protected]> Line 5: CommitDate: 2014-07-01 16:01:02 +0300 Line 6: Line 7: restapi: add network usages field to "add network to data-center" Line 8: action parameters The subject should be one line, and up to 72 characters. Line 9: Line 10: 1. Add network usages field to "add network" action parameters. Line 11: 2. Copy optional parameters definition from "/networks|rel=add" URL to Line 12: "/datacenters/{datacenter:id}/networks|rel=add" URL. Line 8: action parameters Line 9: Line 10: 1. Add network usages field to "add network" action parameters. Line 11: 2. Copy optional parameters definition from "/networks|rel=add" URL to Line 12: "/datacenters/{datacenter:id}/networks|rel=add" URL. Are these parameters really used when adding a network to a data center? If they aren't they shouldn't be documented in the RSDL. Line 13: 3. Re-arrange the parameter blocks for better readability. Line 14: Line 15: Change-Id: Ia5549de3adee242801cd6034426ec67310cbf8d6 Line 16: Bug-Url: https://bugzilla.redhat.com/1085464 -- To view, visit http://gerrit.ovirt.org/29447 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5549de3adee242801cd6034426ec67310cbf8d6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
