Lior Vernia has posted comments on this change. Change subject: restapi: add usages field to "add network to data-center" action params ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/29447/2/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml File backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml: Line 1305: network.vlan.id: 'xs:string', Line 1306: network.ip.address: 'xs:string', Line 1307: network.ip.gateway: 'xs:string', Line 1308: network.ip.netmask: 'xs:string', Line 1309: network.display: 'xs:boolean', If this doesn't belong here, then I wouldn't add it just for it to be removed in a succeeding patch. Especially since I'm not sure the succeeding patch should be merged, see comment there. Line 1310: network.stp: 'xs:boolean', Line 1311: network.mtu: 'xs:int', Line 1312: network.profile_required: 'xs:boolean', Line 1313: network.usages.usage--COLLECTION: {usage: 'xs:string'} -- To view, visit http://gerrit.ovirt.org/29447 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5549de3adee242801cd6034426ec67310cbf8d6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
