Yair Zaslavsky has posted comments on this change. Change subject: engine : Save CommandContext in ContextCache ......................................................................
Patch Set 5: (1 comment) Hi, Can you elaborate more in commit msg about this? In addition, not sure I understand - persist is in DB, right? Then where is the db change in the code, or where do you persist? My idea around this area (and maybe I did not understood from the patch) is to "hold" the command context in memory until CoCo does not need it anymore. Is this basically what you were doing? http://gerrit.ovirt.org/#/c/29501/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/EngineContext.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/EngineContext.java: Line 18: return sessionId; Line 19: } Line 20: Line 21: public EngineContext withSessionId(String sessionId) { Line 22: this.sessionId = sessionId; Hi, I don't understand something here - why persisting an engine session is valid. If engine crashes- the engine session should not exist. Line 23: return this; Line 24: } Line 25: Line 26: @Override -- To view, visit http://gerrit.ovirt.org/29501 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b968f787b60f83cf96411a97dd6380421f724b9 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
