Omer Frenkel has uploaded a new change for review. Change subject: core: change return value of copyImageVDSCommand for better logging ......................................................................
core: change return value of copyImageVDSCommand for better logging currently the return value of copyImageVDSCommand is not initialized, and is defaulted with emtpy guid. this empty guid appears in the engine.log as the result of the command, which is useless and confusing. Changed the return value to have the vdsm task id, which is a better guid to log there. note that the returnVaule of this command is not in use at all, only the createInfo, so this affect only the log. Change-Id: I80d830dcdcdfa38a76b08e5399b2f916349b9b8e Signed-off-by: Omer Frenkel <[email protected]> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CopyImageVDSCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/09/29609/1 diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CopyImageVDSCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CopyImageVDSCommand.java index 0259596..54dc98d 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CopyImageVDSCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CopyImageVDSCommand.java @@ -55,7 +55,7 @@ Guid taskID = new Guid(uuidReturn.mUuid); mCreatedImageId = getParameters().getDstImageId().toString(); - // ReturnValue = new Guid(mCreatedImageId); + setReturnValue(taskID); getVDSReturnValue().setCreationInfo( new AsyncTaskCreationInfo(taskID, AsyncTaskType.copyImage, getParameters().getStoragePoolId())); -- To view, visit http://gerrit.ovirt.org/29609 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I80d830dcdcdfa38a76b08e5399b2f916349b9b8e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
