Lior Vernia has posted comments on this change. Change subject: restapi: remove display field from add network to data-center action parameters ......................................................................
Patch Set 1: (1 comment) Juan, please note inline comment, not sure what the right move here is. http://gerrit.ovirt.org/#/c/29448/1/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml File backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml: Line 3142 Line 3143 Line 3144 Line 3145 Line 3146 Juan, Moti noted that this could be considered breaking the API. Granted, if this field is currently used by anyone then it'll be ignored. However, removing it might raise errors if someone is currently using it, might it not? Which is arguably worse than having a confusing argument that does nothing. -- To view, visit http://gerrit.ovirt.org/29448 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8a135347ccdd3e8692b12a639c4ee214384e5e4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
