Juan Hernandez has posted comments on this change. Change subject: restapi: remove display field from add network to data-center action parameters ......................................................................
Patch Set 1: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/29448/1/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml File backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml: Line 3142 Line 3143 Line 3144 Line 3145 Line 3146 > Note though that we've already done something similar a couple of months ag The content of this file doesn't have any effect on the engine itself, so in that sense it doesn't break backwards compatibility. The content of this file is only used by the engine in order to generate th RSDL document. The Python and Java SDKs are generated from the RSDL document, so those may be affected, and we may be breaking backwards compatibility there. In this particular case we are just removing a parameter that is a field of an entity entity, not a direct parameter of any SDK method, so this doesn't change the signature of any method, thus it doesn't break backwards compatibility of the SDKs. The only real change is that the parameter will be documented differently in the documentation comments of the SDKs, and that affects the CLI, as it inspects that documentation to find out what parameter are mandatory/optional. If someone was using this parameter in the CLI it will continue working, so no backwards compatibility breakage there. -- To view, visit http://gerrit.ovirt.org/29448 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8a135347ccdd3e8692b12a639c4ee214384e5e4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
