anmolbabu has posted comments on this change. Change subject: engine: gluster volume geo replication ......................................................................
Patch Set 2: (4 comments) http://gerrit.ovirt.org/#/c/29605/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepDetailPair.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepDetailPair.java: Line 1: package org.ovirt.engine.core.common.businessentities.gluster; Line 2: Line 3: public class GlusterGeoRepDetailPair extends GlusterGeoRepPair{ Line 4: Long files_syncd; > camel case for variable names ?? Done Line 5: Long files_pending; Line 6: Long bytes_pending; Line 7: Long deletes_pending; Line 8: Long files_skipped; http://gerrit.ovirt.org/#/c/29605/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepMasterVolume.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepMasterVolume.java: Line 3: public class GlusterGeoRepMasterVolume extends GlusterGeoRepVolume { Line 4: Line 5: private static final long serialVersionUID = 6309624603174840111L; Line 6: Line 7: String brickName; > Didnt get this. Does the master volume have only single brick ? Nope.I meant A Pair(GlusterGeoRepPair) Contains only 1 master volume brick Line 8: Line 9: public String getBrickName() { Line 10: return brickName; Line 11: } http://gerrit.ovirt.org/#/c/29605/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepPair.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepPair.java: Line 2: Line 3: import java.io.Serializable; Line 4: Line 5: Line 6: public class GlusterGeoRepPair implements Serializable{ > hasCode and equals methods required here ?? Done Line 7: GlusterGeoRepVolume slaveVolume; Line 8: GlusterGeoRepMasterVolume masterVolume; Line 9: String pairStatus; Line 10: String checkPointStatus; http://gerrit.ovirt.org/#/c/29605/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepVolume.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepVolume.java: Line 7: public class GlusterGeoRepVolume implements Serializable{ Line 8: Line 9: private static final long serialVersionUID = -4810726301877481112L; Line 10: Line 11: String nodeHostName; > I feel hostName is better name Done.I was just copying the names from xml and turning them camel case :)).I'll change it :)) Line 12: String name; Line 13: Guid id; Line 14: Guid nodeUuid; Line 15: -- To view, visit http://gerrit.ovirt.org/29605 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If86abee9276b8f2e4bdd4a4276dbbd76b9514c68 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
