Sahina Bose has posted comments on this change. Change subject: engine: gluster volume geo replication entities ......................................................................
Patch Set 4: (4 comments) Please implement equals and hashcode method for entities http://gerrit.ovirt.org/#/c/29605/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepSession.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepSession.java: Line 3: import java.io.Serializable; Line 4: Line 5: import org.ovirt.engine.core.compat.Guid; Line 6: Line 7: public class GlusterGeoRepSession implements Serializable{ Should extend IVdcQueryable and implement BusinessEntityWithStatus Line 8: Line 9: private static final long serialVersionUID = 1L; Line 10: Line 11: Guid masterVolumeId; Line 13: String slaveNodeHostName; Line 14: Guid slaveNodeUuid; Line 15: String slaveVolumeName; Line 16: Guid sessionId; Line 17: String status; Create an enum for GeoRepStatus Line 18: Guid slaveVolumeId; Line 19: Line 20: public Guid getMasterVolumeId() { Line 21: return masterVolumeId; http://gerrit.ovirt.org/#/c/29605/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepSessionDetails.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepSessionDetails.java: Line 12: Guid sessionId; Line 13: Guid masterBrickId; Line 14: Guid slaveNodeUuid; Line 15: String slaveNodeHostName; Line 16: String status; Can you create an enum for status? Line 17: String checkPointStatus; Line 18: String crawlStatus; Line 19: Long files_syncd; Line 20: Long files_pending; http://gerrit.ovirt.org/#/c/29605/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeEntity.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeEntity.java: Line 78: private GlusterAsyncTask asyncTask; Line 79: Line 80: private GlusterVolumeAdvancedDetails advancedDetails; Line 81: Line 82: private boolean isGeoRepStarted; Why is this required? Will this be stored in the database? Line 83: Line 84: public GlusterVolumeEntity() { Line 85: options = new LinkedHashMap<String, GlusterVolumeOptionEntity>(); Line 86: bricks = new ArrayList<GlusterBrickEntity>(); -- To view, visit http://gerrit.ovirt.org/29605 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If86abee9276b8f2e4bdd4a4276dbbd76b9514c68 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
