Lior Vernia has posted comments on this change. Change subject: webadmin: Validate no duplicate network names on import ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/30650/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/ImportNetworksModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/ImportNetworksModel.java: Line 212: if (!valid) { Line 213: Frontend.getInstance() Line 214: .getFrontendFailureEvent() Line 215: .raise(this, Line 216: new FrontendFailureEventArgs(Collections.singletonList(new Message(ConstantsManager.getInstance() > This error is the convention for backend errors. Not worth the effort in my opinion, when it comes to rendering these cells. I would prefer to abandon the patch and close it as WONTFIX then to properly fix this. Line 217: .getMessages() Line 218: .duplicateNetworkNamesOnImport(StringUtils.join(duplicateNames, ", ")))))); //$NON-NLS-1$ Line 219: } Line 220: http://gerrit.ovirt.org/#/c/30650/2/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java File frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java: Line 280: String urlSchemeInvalidScheme(String passedScheme, String allowedSchemes); Line 281: Line 282: @DefaultMessage("Changing the URL of this provider might hurt the proper functioning of the following entities provided by it.\n\n{0}") Line 283: String providerUrlWarningText(String providedEntities); Line 284: > Whitespace Done Line 285: @DefaultMessage("Cannot import networks, the following network names appear more than once: {0}. Either modify some of these networks'' names so that there is no duplication, or decide which of them should not be imported.") Line 286: String duplicateNetworkNamesOnImport(String networkNames); Line 287: Line 288: // Vnic -- To view, visit http://gerrit.ovirt.org/30650 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If63d450bfc8d666ebb383e29fdfe43fcf879db78 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
