Liron Aravot has posted comments on this change. Change subject: engine : Zombie tasks should endWithFailure ......................................................................
Patch Set 1: Code-Review-1 (2 comments) copy paste that i'd like to avoid, -1 for visibility http://gerrit.ovirt.org/#/c/31038/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/SPMAsyncTask.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/SPMAsyncTask.java: Line 22: public class SPMAsyncTask implements SPMTask { Line 23: Line 24: protected final CommandCoordinator coco; Line 25: Line 26: private boolean zombieTask = false; please remove the =false when your rebase, that's the default anyway so no need to add that. Line 27: Line 28: public SPMAsyncTask(CommandCoordinator coco, AsyncTaskParameters parameters) { Line 29: this.coco = coco; Line 30: setParameters(parameters); Line 221: setLastStatusAccessTime(); Line 222: } Line 223: Line 224: // A zombie task that has been stopped and cleared needs to failed Line 225: if (isZombieTask()) { please just add the condition isZombieTask() to the if clause in line 233 (as: || isZombieTask()), the code within is the same..lets avoid the copy. Line 226: getParameters().getDbAsyncTask().getTaskParameters().setTaskGroupSuccess(false); Line 227: ExecutionHandler.endTaskStep(privateParameters.getDbAsyncTask().getStepId(), JobExecutionStatus.FAILED); Line 228: onTaskEndFailure(); Line 229: } -- To view, visit http://gerrit.ovirt.org/31038 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01125b507ab116440277bebdd7190a7daecbd810 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
