Liron Aravot has posted comments on this change. Change subject: engine : Zombie tasks should endWithFailure ......................................................................
Patch Set 2: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/31038/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/SPMAsyncTask.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/SPMAsyncTask.java: Line 221: setLastStatusAccessTime(); Line 222: } Line 223: Line 224: // A zombie task or a task that belongs to a partially submitted command Line 225: // needs to be failed no matter what the status of the task is. perhaps that comment could be phrased bit better, consider it Line 226: if (isZombieTask() || isPartiallyCompletedCommandTask()) { Line 227: getParameters().getDbAsyncTask().getTaskParameters().setTaskGroupSuccess(false); Line 228: ExecutionHandler.endTaskStep(privateParameters.getDbAsyncTask().getStepId(), JobExecutionStatus.FAILED); Line 229: onTaskEndFailure(); -- To view, visit http://gerrit.ovirt.org/31038 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01125b507ab116440277bebdd7190a7daecbd810 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
