Alon Bar-Lev has posted comments on this change. Change subject: core: Add engine-java-launcher script ......................................................................
Patch Set 4: I was just about to ask why there is no such script :) That's great! I think we should not distinguish between dev and prod, but have configuration of product with file locations. Usually I am for putting /etc/ovirt-engine/env.sh or something similar with environment variables of the location of javalib, pythonlib etc... This can be overridden by environment variable so that dev users may have their own env.sh with custom locations. It is good to have this in sh format as it may be used by other utilities, and python wrappers can easily use the environment. If we do this right, we can also install product at /usr/local/ without any issue, and we can do side-by-side installation of two instances. I am not sure the /etc/sysconfig/ovirt-engine location is good for none service files. We already have /etc/ovirt-engine. Or more precisely I don't understand for what used. Can you please explain (my java knowledge may be weak), we you do the fuzzy search and not just use wildcards? For example ovirt-engine*.jar. Thanks! Alon. -- To view, visit http://gerrit.ovirt.org/5129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6eed7495f8d380656ef413596d7848618e395c96 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
