Juan Hernandez has posted comments on this change.

Change subject: core: Add engine-java-launcher script
......................................................................


Patch Set 4:

So, leaving aside the discussion about the location of the configuration file, 
something like this:

diff --git a/packaging/fedora/engine-java-launcher.py 
b/packaging/fedora/engine-java-launcher.py
index 94ad67c..dd06de5 100644
--- a/packaging/fedora/engine-java-launcher.py
+++ b/packaging/fedora/engine-java-launcher.py
@@ -60,7 +60,7 @@ aliasedJars = {
 
 def loadSysconfig():
     # Load the configuration file:
-    engineSysconfigFile = "/etc/sysconfig/ovirt-engine"
+    engineSysconfigFile = os.getenv("ENGINE_SYSCONFIG", 
"/etc/sysconfig/ovirt-engine")
     global engineSysconfig
     if os.path.exists(engineSysconfigFile):
         engineSysconfig = configobj.ConfigObj(engineSysconfigFile)

--
To view, visit http://gerrit.ovirt.org/5129
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6eed7495f8d380656ef413596d7848618e395c96
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to