Yair Zaslavsky has posted comments on this change. Change subject: restapi : Create user API fails in REST & Java ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/31226/2/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java: Line 81: VdcQueryReturnValue result = runQuery(VdcQueryType.Search, params); Line 82: if (!result.getSucceeded()) { Line 83: backendFailure(result.getExceptionString()); Line 84: } Line 85: return castQueryResultToEntity(clz, result, params.getSearchPattern()); can you please elaborate why the change here? Line 86: } catch (Exception e) { Line 87: return handleError(clz, e, false); Line 88: } Line 89: } http://gerrit.ovirt.org/#/c/31226/2/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendGroupsResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendGroupsResource.java: Line 211: return null; Line 212: } Line 213: Line 214: @Override Line 215: protected SearchParameters createSearchParameters(SearchType searchType, String constraint) { so this is needed for backwards compability? Line 216: if (SearchType.DirectoryGroup.equals(searchType)) { Line 217: return new DirectorySearchParameters(constraint, searchType); Line 218: } Line 219: return super.createSearchParameters(searchType, constraint); -- To view, visit http://gerrit.ovirt.org/31226 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifed7f39b5b706482198afd74163791105b1d956a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
