Alon Bar-Lev has posted comments on this change. Change subject: restapi : Create user API fails in REST & Java ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/31226/2/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendGroupsResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendGroupsResource.java: Line 211: return null; Line 212: } Line 213: Line 214: @Override Line 215: protected SearchParameters createSearchParameters(SearchType searchType, String constraint) { > so this is needed for backwards compability? no... to return DirectorySearchParameters instead of SearchParameters please see my comments, I think that there should be no DirectorySearchParametrers and namespace moved into the search pattern. Line 216: if (SearchType.DirectoryGroup.equals(searchType)) { Line 217: return new DirectorySearchParameters(constraint, searchType); Line 218: } Line 219: return super.createSearchParameters(searchType, constraint); -- To view, visit http://gerrit.ovirt.org/31226 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifed7f39b5b706482198afd74163791105b1d956a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
