Vered Volansky has posted comments on this change. Change subject: core: Add memory allocation check to hibernate VM ......................................................................
Patch Set 10: (2 comments) http://gerrit.ovirt.org/#/c/30883/10/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java: Line 273: if (getStorageDomainId().equals(Guid.Empty)) { Line 274: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_NO_SUITABLE_DOMAIN_FOUND); Line 275: } Line 276: Line 277: return validateDomainWithinThresholds(); > why do we need to validate if we get SD that has free space, it looks like Not exactly, depends on the threshold value in the configuration, there can be a case where the threshold has been met, yet there's enough space for the request. Line 278: } Line 279: Line 280: protected boolean validateDomainWithinThresholds() { Line 281: StorageDomain storageDomain = getStorageDomain(); http://gerrit.ovirt.org/#/c/30883/10/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/HibernateVmCommandTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/HibernateVmCommandTest.java: Line 15: import org.ovirt.engine.core.compat.Guid; Line 16: import org.ovirt.engine.core.dao.StorageDomainDAO; Line 17: Line 18: import static org.junit.Assert.assertThat; Line 19: import static org.hamcrest.CoreMatchers.*; > please unwrap this to a series of "import static org.hamcrest.CoreMatchers. Will do. Line 20: import static org.mockito.Matchers.any; Line 21: import static org.mockito.Mockito.doReturn; Line 22: import static org.mockito.Mockito.spy; Line 23: import static org.mockito.Mockito.when; -- To view, visit http://gerrit.ovirt.org/30883 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1250e6ea8d67f8026d66cf06589538343d39756a Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
