Omer Frenkel has posted comments on this change. Change subject: core: Add memory allocation check to hibernate VM ......................................................................
Patch Set 10: (1 comment) http://gerrit.ovirt.org/#/c/30883/10/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java: Line 273: if (getStorageDomainId().equals(Guid.Empty)) { Line 274: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_NO_SUITABLE_DOMAIN_FOUND); Line 275: } Line 276: Line 277: return validateDomainWithinThresholds(); > Not exactly, depends on the threshold value in the configuration, there can so the first check should do whatever this check is doing, because if i have 2 domains, that both have enough space, but one will exceed the threshold, we need to make sure to select the one that we can use, if we will choose the other, its a bug. Line 278: } Line 279: Line 280: protected boolean validateDomainWithinThresholds() { Line 281: StorageDomain storageDomain = getStorageDomain(); -- To view, visit http://gerrit.ovirt.org/30883 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1250e6ea8d67f8026d66cf06589538343d39756a Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
