Gilad Chaplik has posted comments on this change.
Change subject: webadmin: separate storage & cluster quota
......................................................................
Patch Set 8: (17 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaListModel.java
Line 178: qModel.getSpecificStorageQuota().setEntity(true);
no, I need to set specific storage without any limitation to create a quota
with no storage limitations/ it is kind of a hack: to create a cluster quota,
you set cluster parameters and specific storage parameters without any storage
domains.
Line 179: qModel.setClusterQuota(true);
that's binded to the view and not a model parameter.
the clusterQuota will be refactored into an enum (QuotaType = cluster,
storage...)
Line 181: qModel.getSpecificClusterQuota().setEntity(true);
same as before.
Line 218: if (isQuotaForCluster) {
can do it in a future refactoring.
Line 225:
qModel.getAllDataCenterClusters().setItems(new ArrayList<QuotaVdsGroup>());
that's a bug.
Line 260: &&
!storage.getstorage_domain_type().equals(StorageDomainType.Data)) {
Done
Line 315: } else if (model.getAllDataCenterClusters().getItems() !=
null) {
I agree, but the in the former code, it was always initialized. did it to do a
quick fix.
Line 335: } else if (model.getAllDataCenterStorages().getItems() !=
null) {
same
Line 414: qModel.setClusterQuota(false);
that's an indication if the view will be cluster/or storage, in edit.
I need to replace it with an enum.
Line 643: } else if (command.equals(getCreateQuotaClusterCommand())) {
Done
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaModel.java
Line 409: getSpecificClusterQuota().setIsValid(true);
I don't change properties, just set the validation to true before I start
testing it.
Line 412: empty = false;
Done
Line 415: if (getAllDataCenterClusters().getItems() != null) {
it could happen, if it's storage quota - this will be empty.
Line 419: break;
Done
Line 424: if (empty && getAllDataCenterStorages().getItems() !=
null) {
don't get you/.
Line 428: break;
Done
....................................................
File
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java
Line 1381: @DefaultStringValue("Quota must contain limitations")
in case you select specific limitation and don't select any entity, e.g.
add storage quota, select specific and don't select any storage domain -> the
radiobutton will be marked with this tooltip.
--
To view, visit http://gerrit.ovirt.org/6434
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8d23a8232d6b2cd8dcf4dfbde972dd9bfdd6420
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
