Ayal Baron has posted comments on this change.
Change subject: webadmin: separate storage & cluster quota
......................................................................
Patch Set 8: (8 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaListModel.java
Line 178: qModel.getSpecificStorageQuota().setEntity(true);
So you should move this to another method and name it properly. Something
like: setUnlimitedStorageQuota or something.
Line 181: qModel.getSpecificClusterQuota().setEntity(true);
same as before ;)
Line 218: if (isQuotaForCluster) {
Obviously seeing as I commented on a merged patch...
But code should not stay this way. Refactoring now is simple, later it will
not be as simple.
Line 315: } else if (model.getAllDataCenterClusters().getItems() !=
null) {
so please fix properly
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaModel.java
Line 409: getSpecificClusterQuota().setIsValid(true);
Can't say I understand...
why are you setting it to valid before validating?.
Line 415: if (getAllDataCenterClusters().getItems() != null) {
Empty yes, null no.
Line 424: if (empty && getAllDataCenterStorages().getItems() !=
null) {
This entire block is "if (empty)"
so when we enter here clearly emtpy == True.
Then we have 'if getAllData...' and then if (empty && getAllData)
so if first if getAllData evaluates to true then no need to check it again and
if it's false then we won't enter second if anyway.
....................................................
File
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java
Line 1381: @DefaultStringValue("Quota must contain limitations")
s/Quota must contain limitation/No entity selected for specific quota/ ?
--
To view, visit http://gerrit.ovirt.org/6434
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8d23a8232d6b2cd8dcf4dfbde972dd9bfdd6420
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
