Alon Bar-Lev has posted comments on this change. Change subject: packaging: build: fixed engine first clean build ......................................................................
Patch Set 1: (4 comments) I do not understand what is the actual fix http://gerrit.ovirt.org/#/c/32635/1/pom.xml File pom.xml: Line 413: </snapshots> Line 414: </repository> Line 415: <!-- temporary until vdsm-jsonrpc-java-client and ovirt-host-deploy 1.3.0 released --> Line 416: <repository> Line 417: <id>sonatype.oss.snapshot.repo</id> this should not be important. Line 418: <name>Sonatype OSS Snapshot Respository</name> Line 419: <url>http://oss.sonatype.org/content/repositories/snapshots</url> Line 420: <snapshots> Line 421: <enabled>true</enabled> Line 414: </repository> Line 415: <!-- temporary until vdsm-jsonrpc-java-client and ovirt-host-deploy 1.3.0 released --> Line 416: <repository> Line 417: <id>sonatype.oss.snapshot.repo</id> Line 418: <name>Sonatype OSS Snapshot Respository</name> this also is not important Line 419: <url>http://oss.sonatype.org/content/repositories/snapshots</url> Line 420: <snapshots> Line 421: <enabled>true</enabled> Line 422: </snapshots> Line 415: <!-- temporary until vdsm-jsonrpc-java-client and ovirt-host-deploy 1.3.0 released --> Line 416: <repository> Line 417: <id>sonatype.oss.snapshot.repo</id> Line 418: <name>Sonatype OSS Snapshot Respository</name> Line 419: <url>http://oss.sonatype.org/content/repositories/snapshots</url> trailing slash should not matter Line 420: <snapshots> Line 421: <enabled>true</enabled> Line 422: </snapshots> Line 423: <releases> Line 421: <enabled>true</enabled> Line 422: </snapshots> Line 423: <releases> Line 424: <enabled>false</enabled> Line 425: </releases> not sure why this is needed, and we do want to publish temporary releases Line 426: </repository> Line 427: </repositories> Line 428: <pluginRepositories> Line 429: <pluginRepository> -- To view, visit http://gerrit.ovirt.org/32635 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e81cd257db9c3d57d5e626ab14f5027738b54c5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
