Juan Hernandez has posted comments on this change. Change subject: packaging: build: fixed engine first clean build ......................................................................
Patch Set 1: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/32635/1/pom.xml File pom.xml: Line 421: <enabled>true</enabled> Line 422: </snapshots> Line 423: <releases> Line 424: <enabled>false</enabled> Line 425: </releases> > as juan wrote, all that is required is removing the snapshots from somewher Moving that repository definition from restapi-parent to the root POM is what should have been done in the first place. However that hasn't been tested, and this patch has, and fixes a real issue, so in my opinion it can be merged. Line 426: </repository> Line 427: </repositories> Line 428: <pluginRepositories> Line 429: <pluginRepository> -- To view, visit http://gerrit.ovirt.org/32635 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e81cd257db9c3d57d5e626ab14f5027738b54c5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
