Alon Bar-Lev has posted comments on this change. Change subject: build: maven: move all repositories into top level ......................................................................
Patch Set 2: (6 comments) http://gerrit.ovirt.org/#/c/32756/2/backend/manager/modules/restapi/pom.xml File backend/manager/modules/restapi/pom.xml: Line 32 Line 33 Line 34 Line 35 Line 36 > Removing this ^ shouldn't be part of this patch. Done Line 45 Line 46 Line 47 Line 48 Line 49 > If this repository is moved to somewhere else, then the id should be preser the same can be said about the other id... I left the repo id of the root pom. Line 61 Line 62 Line 63 Line 64 Line 65 > This repository ^ should be kept here, as PowerMock is used only by the RES all repositories should be in root pom.xml to avoid future issues. http://gerrit.ovirt.org/#/c/32756/2/pom.xml File pom.xml: Line 379: <repository> Line 380: <id>jboss-thirdparty-releases</id> Line 381: <name>JBoss Thirdparty Releases</name> Line 382: <url>https://repository.jboss.org/nexus/content/repositories/thirdparty-releases</url> Line 383: </repository> > This ^ repository should be removed, after veryfing that it isn't needed. Done Line 384: <repository> Line 385: <id>java.net</id> Line 386: <name>Java.net repo</name> Line 387: <layout>default</layout> Line 419: </repository> Line 420: <repository> Line 421: <id>jboss.repo</id> Line 422: <url>https://repository.jboss.org/nexus/content/repositories/releases</url> Line 423: </repository> > This ^ repository should be removed, after verifying that it isn't needed. Done Line 424: <repository> Line 425: <id>powermock-repo</id> Line 426: <url>http://powermock.googlecode.com/svn/repo/</url> Line 427: </repository> Line 423: </repository> Line 424: <repository> Line 425: <id>powermock-repo</id> Line 426: <url>http://powermock.googlecode.com/svn/repo/</url> Line 427: </repository> > This ^ repository shouldn't be here, only in the RESTAPI parent POM, as no can we have ordering? I put it last... I expect it will be queried last. Line 428: <repository> Line 429: <!-- temporary until vdsm-jsonrpc-java-client and ovirt-host-deploy 1.3.0 released --> Line 430: <id>sonatype-snapshots</id> Line 431: <url>http://oss.sonatype.org/content/repositories/snapshots/</url> -- To view, visit http://gerrit.ovirt.org/32756 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0599fc0293ab3e3f11b5fb7adb22c76b58d590bf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
