Juan Hernandez has posted comments on this change. Change subject: build: maven: move all repositories into top level ......................................................................
Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/32756/2/backend/manager/modules/restapi/pom.xml File backend/manager/modules/restapi/pom.xml: Line 45 Line 46 Line 47 Line 48 Line 49 > the same can be said about the other id... I left the repo id of the root p Exactly, the id in the root POM is what is wrong, and introduced it is what caused the problem, so that is what must be fixed. Line 61 Line 62 Line 63 Line 64 Line 65 > all repositories should be in root pom.xml to avoid future issues. No, this one should be only the RESTAPI parent POM. http://gerrit.ovirt.org/#/c/32756/2/pom.xml File pom.xml: Line 423: </repository> Line 424: <repository> Line 425: <id>powermock-repo</id> Line 426: <url>http://powermock.googlecode.com/svn/repo/</url> Line 427: </repository> > can we have ordering? I put it last... I expect it will be queried last. It is not about ordering, but about sending queries to this repository for any missing artifact. Line 428: <repository> Line 429: <!-- temporary until vdsm-jsonrpc-java-client and ovirt-host-deploy 1.3.0 released --> Line 430: <id>sonatype-snapshots</id> Line 431: <url>http://oss.sonatype.org/content/repositories/snapshots/</url> -- To view, visit http://gerrit.ovirt.org/32756 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0599fc0293ab3e3f11b5fb7adb22c76b58d590bf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
