Roy Golan has posted comments on this change. Change subject: core: monitoring - separate Host Monitoring and Vm Moniting ......................................................................
Patch Set 12: (1 comment) http://gerrit.ovirt.org/#/c/28173/12/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVmVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVmVDSCommand.java: Line 24: super(parameters); Line 25: } Line 26: Line 27: @Override Line 28: protected void executeVmCommand() { > How do we make sure that vdsManager is not null? Do we expect NPEs here? we don't use it anymore Line 29: final VM vm = getParameters().getVm(); Line 30: vm.setLastStartTime(new Date()); Line 31: // if the VM is not suspended, it means that if there is 'hibernation volume' Line 32: // set, it is actually memory from snapshot, thus it should be cleared right -- To view, visit http://gerrit.ovirt.org/28173 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54c6091a3996c23a4b70c7ef89412d34f1b58e34 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
