Maor Lipchuk has posted comments on this change. Change subject: core: Get all unregisterd entities for Storage Domain ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/32744/6/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/UnregisteredOVFDataDAOTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/UnregisteredOVFDataDAOTest.java: Line 67: @Test Line 68: public void testGetAllEntitiesForStorageDomain() { Line 69: List<OvfEntityData> ovfEntityDataList = Line 70: dao.getAllForStorageDomainByEntityType(FixturesTool.STORAGE_DOAMIN_NFS2_1, null); Line 71: assertTrue("There should be entities fetched for the specified storage domain", !ovfEntityDataList.isEmpty()); > The production code assumes that null is never returned, therefore, we shou I don't think we ever assumed that a null list can be returned from a dao method. For example you can take a look at SimpleJdbcCallsHandler#executeRead at line 96, executeReadList is being called there, and we always assume that the list can be null by calling results.isEmpty().... Regarding the "bogus domain id" - will be added Line 72: assertEquals("A Template and a VM should be fetched for the specified storage domain", Line 73: 2, Line 74: ovfEntityDataList.size()); Line 75: } -- To view, visit http://gerrit.ovirt.org/32744 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fa749c309381a9f034dc8e6ea499740c33f8990 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
