Maor Lipchuk has posted comments on this change. Change subject: core: Get all unregisterd entities for Storage Domain ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/32744/7/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/UnregisteredOVFDataDAOTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/UnregisteredOVFDataDAOTest.java: Line 69: List<OvfEntityData> ovfEntityDataList = Line 70: dao.getAllForStorageDomainByEntityType(FixturesTool.STORAGE_DOAMIN_NFS2_1, null); Line 71: assertEquals("A Template and a VM should be fetched for the specified storage domain", Line 72: 2, Line 73: ovfEntityDataList.size()); > please check the return value to see that actually vm and template are retu I don't think it is necessary, since it will make the test to be too coupled with the fixtures xml IMO Line 74: } Line 75: Line 76: @Test Line 77: public void testGetAllEntitiesForStorageDomainWithNoUnregisteredEntities() { -- To view, visit http://gerrit.ovirt.org/32744 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fa749c309381a9f034dc8e6ea499740c33f8990 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
