mooli tayer has posted comments on this change. Change subject: notifier: modify the oid schema for SNMP notification. ......................................................................
Patch Set 3: (2 comments) I'm now integrating with Zabbix. http://gerrit.ovirt.org/#/c/32951/3/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java: Line 137: v2pdu.add(new VariableBinding(SnmpConstants.sysUpTime, Line 138: new TimeTicks((System.nanoTime() - nanoStart) / 10000000))); Line 139: // { [baseoid] notifications(1) bc(0) audit(1) } Line 140: v2pdu.add(new VariableBinding(SnmpConstants.snmpTrapOID, Line 141: new OID(profile.oid).append(1).append(0).append(1))); > this should be SnmpConstants.getTrapOID() ? I don't like this helper method, to me it's more confusing. As the generic oid does not exist any longer in snmp v2. Maybe if we had to send traps with generic trap prefix (the new OID for predefined traps: cold start warm start etc in V2c.) But we always will do profile.oid + 0 + something. But if you insist: SnmpConstants.getTrapOID(new OID(profile.oid).append(1),6,1 ) Line 142: Line 143: int auditLogId = AuditLogType.UNASSIGNED.getValue(); Line 144: try { Line 145: auditLogId = AuditLogType.valueOf(event.getName()).getValue(); http://gerrit.ovirt.org/#/c/32951/3/packaging/doc/mibs/OVIRT-MIB.txt File packaging/doc/mibs/OVIRT-MIB.txt: Line 75: STATUS current Line 76: DESCRIPTION "notifications defined in SMIv2 modules are required to be listed in a group" Line 77: ::= { ovirtEngineNotifierGroups 1 } Line 78: Line 79: ovirtEngineNotifierNotificationsBC OBJECT IDENTIFIER ::= { ovirtEngineNotifierNotifications 0 } > you can remove the BC, these are the notifications, they can be used for sn Maybe I don't understand you but, even for enterprise defined notifications if I remove BC I get from smilint: ./OVIRT-MIB.txt:67: warning: notification `ovirtEngineNotifierNotificationsComplianceAudit' is not reverse mappable. Line 80: Line 81: ovirtEngineNotifierNotificationsBCAudit NOTIFICATION-TYPE Line 82: OBJECTS { Line 83: ovirtEngineNotifierName, -- To view, visit http://gerrit.ovirt.org/32951 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic8a06063f8ebbbe4d05783cb25036e870a6be3b7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
