mooli tayer has posted comments on this change. Change subject: notifier: modify the oid schema for SNMP notification. ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/32951/3/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/transport/snmp/Snmp.java: Line 137: v2pdu.add(new VariableBinding(SnmpConstants.sysUpTime, Line 138: new TimeTicks((System.nanoTime() - nanoStart) / 10000000))); Line 139: // { [baseoid] notifications(1) bc(0) audit(1) } Line 140: v2pdu.add(new VariableBinding(SnmpConstants.snmpTrapOID, Line 141: new OID(profile.oid).append(1).append(0).append(1))); > in order to allow conversion to snmpv1 you need to define enterprise specif Will change so you will be happy :) Line 142: Line 143: int auditLogId = AuditLogType.UNASSIGNED.getValue(); Line 144: try { Line 145: auditLogId = AuditLogType.valueOf(event.getName()).getValue(); http://gerrit.ovirt.org/#/c/32951/3/packaging/doc/mibs/OVIRT-MIB.txt File packaging/doc/mibs/OVIRT-MIB.txt: Line 75: STATUS current Line 76: DESCRIPTION "notifications defined in SMIv2 modules are required to be listed in a group" Line 77: ::= { ovirtEngineNotifierGroups 1 } Line 78: Line 79: ovirtEngineNotifierNotificationsBC OBJECT IDENTIFIER ::= { ovirtEngineNotifierNotifications 0 } > are you suggesting that the naming has any meaning? It was backward compatible. Now that I think about it can define ovirtEngineNotifierNotifications as ovirtEngineNotifier 0 and than I will not need this one. Will test. Line 80: Line 81: ovirtEngineNotifierNotificationsBCAudit NOTIFICATION-TYPE Line 82: OBJECTS { Line 83: ovirtEngineNotifierName, -- To view, visit http://gerrit.ovirt.org/32951 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic8a06063f8ebbbe4d05783cb25036e870a6be3b7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
