Yair Zaslavsky has posted comments on this change. Change subject: core: remove commons httpclient from provider proxy ......................................................................
Patch Set 3: (4 comments) http://gerrit.ovirt.org/#/c/33458/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java: Line 317: if (read > -1) { Line 318: bytesOs.write(chunk, 0, read); Line 319: } else { Line 320: break; Line 321: } > oh, you meant some inputStreamToOutputStream method? Done Line 322: } Line 323: result = bytesOs.toByteArray(); Line 324: handleResponseCode(connection.getResponseCode()); Line 325: } catch (SSLException e) { Line 320: break; Line 321: } Line 322: } Line 323: result = bytesOs.toByteArray(); Line 324: handleResponseCode(connection.getResponseCode()); > ok Done Line 325: } catch (SSLException e) { Line 326: throw new VdcBLLException(VdcBllErrors.PROVIDER_SSL_FAILURE, e.getMessage()); Line 327: } catch (IOException e) { Line 328: handleException(e); http://gerrit.ovirt.org/#/c/33458/3/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssl/AuthSSLProtocolSocketFactory.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssl/AuthSSLProtocolSocketFactory.java: > not sure what this class is. ok, my bad. got screwed in formatting. Bare in mind I placed @Depracated. Since I'm dealing only with Foreman now, I wish to defer the discussion on it later. Line 1: /* Line 2: * $HeadURL$ Line 3: * $Revision$ Line 4: * $Date$ http://gerrit.ovirt.org/#/c/33458/3/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssl/SecureConnector.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssl/SecureConnector.java: > But what about the TrustStore? Ok, I think I understand, I think that it should not exist in ProxyServletBase, we should have the ability to open connection not just from servlet code, what do you think? Line 1: package org.ovirt.engine.core.utils.ssl; Line 2: Line 3: Line 4: import java.net.URL; -- To view, visit http://gerrit.ovirt.org/33458 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I727d34c33f357b93560d4b5a1784b3733b7fa293 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
