Alon Bar-Lev has posted comments on this change. Change subject: core: remove commons httpclient from provider proxy ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/33458/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java: Line 343: Line 344: URL hostUrl = getUrl(); Line 345: Connection connection = null; Line 346: try { Line 347: if (isSecured()) { > This is the based on the logic of this specific class. provider should not care if it is secure or not... all it needs to provide is url. this logic should be removed. Line 348: if (hostUrl.getPort() == -1) { Line 349: hostUrl = Line 350: createURLWithDefaultPort( Line 351: hostUrl, http://gerrit.ovirt.org/#/c/33458/3/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssl/SecureConnector.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssl/SecureConnector.java: > Ok, I think I understand, I think that it should not exist in ProxyServletB if you extract it to uutils, both can use uutils. Line 1: package org.ovirt.engine.core.utils.ssl; Line 2: Line 3: Line 4: import java.net.URL; -- To view, visit http://gerrit.ovirt.org/33458 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I727d34c33f357b93560d4b5a1784b3733b7fa293 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
