Piotr Kliczewski has posted comments on this change. Change subject: core: protocol fall back for older vdsms ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/33728/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/transport/ProtocolDetector.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/transport/ProtocolDetector.java: Line 47: task.get(timeout, TimeUnit.SECONDS); Line 48: Line 49: if (returnValue.getSucceeded()) { Line 50: return true; Line 51: } > Sure I will check. TimeoutException is indeed handled in FutureVDSCommand but it is declared in FutureVDSCall on method get(long, TimeUnit) so we need to have it. I agree that we do not need it but it is required by interface (never thrown from it). Line 52: } catch (TimeoutException ignored) { Line 53: } Line 54: return false; Line 55: } -- To view, visit http://gerrit.ovirt.org/33728 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie6f48bec60b520c089f326f8c5e79aec288ff3d6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
