Saggi Mizrahi has posted comments on this change. Change subject: core: protocol fall back for older vdsms ......................................................................
Patch Set 2: Alon, in principal, you are correct. Protocol should be unrelated to cluster level. But, this can only be true if the assumption is that the API is identical. This is incorrect. In the future, when we push support for AMQP it will be independent of cluster level. But json support is mandatory for a 3.5 cluster. This is so that we can start using features available with messaging that are impossible with XMLRPC in 3.6. The only reason this fallback exists is to handle the use case where you try and add an old VDSM to a 3.5 cluster. Since it doesn't respond in jsonrpc you can't tell if the host can't be added because it doesn't support jsonrpc or because it's just disconnected. This fallback solves that ambiguity. All other communication *must* be done with json-rpc. -- To view, visit http://gerrit.ovirt.org/33728 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie6f48bec60b520c089f326f8c5e79aec288ff3d6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
