mooli tayer has posted comments on this change.
Change subject: core: AuditLogDirector should not have static methods
......................................................................
Patch Set 13:
I'm simply commenting;
This is not DI ready:
new AuditLogDirector().log(this, AuditLogType.x);
While this is:
private AuditLogDirector auditLogDirector;
...
setAuditLogDirector( AuditLogDirector auditLogDirector){
this.auditLogDirector = auditLogDirector;
}
Since you are only missing '@X'.
Having said that, if you would rather do that in a different change
for your own reasons, that is fine by me.
--
To view, visit http://gerrit.ovirt.org/29589
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id88ecd68fdc469bd0ddfdf4ae9c7f6d22ff8e8bf
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Martin Mucha <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: mooli tayer <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
