Martin Mucha has posted comments on this change. Change subject: core: AuditLogDirector should not have static methods ......................................................................
Patch Set 14: for me it's easier add annotation to already existing fields, where possible and where not replace "new AuditLoggerDirector()." with "auditLoggerDirector." and fix few errors. —— I've did this in following draft. I did this only for Commands, since I didn't find any evidences that classes using AuditLogDirector are managed. But Commands are. http://gerrit.ovirt.org/33901 Please look at it, there's some flaw, I don't know which, but AuditLoggerDirector isn't in module dal isn't discovered by cdi for some reason. -- To view, visit http://gerrit.ovirt.org/29589 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id88ecd68fdc469bd0ddfdf4ae9c7f6d22ff8e8bf Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
