mooli tayer has posted comments on this change.
Change subject: core: AuditLogType.UNASSIGNED should not be logged
......................................................................
Patch Set 3:
I see.
what about dropping the new logType.shouldBeLogged() and instead:
if (logType != null && AuditLogType.forValue(logType.getValue) !=
AuditLogType.UNASSIGNED){...}
Than you can deprecate UNASSIGNED and phase in returning null instead.
--
To view, visit http://gerrit.ovirt.org/33359
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I97bf90264d1a1b3d8ea571daa9346d1f6b6d18d1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Martin Mucha <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: mooli tayer <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
