Martin Mucha has posted comments on this change. Change subject: core: AuditLogType.UNASSIGNED should not be logged ......................................................................
Patch Set 3: yes, that's also a way. But I'm concerned about this, because: - 29 usages ~ 20 file changes. I'm not sure if this change can make it through CR and get merged. - people are used to UNASSIGNED, and probably want to use this "know-how". - replacing UNASSIGNED with null just swaps one special value with another one but 'null' already has one: 'uninitialized/unset'. Renaming misleading UNASSIGNED to DO-NOT-LOG, would make more good(but contradicts 1) and 2) ). But I can see your point; I we'd make statement, that we cannot log 'untyped' messages, then passing null can be considered as turning it off. I'd just like it better via some more explicit way, where UNASSIGNED is slight more explicit, DO-NOT-LOG even more explicit and expressing it via special property would be ideal. Don't get me wrong, I can do it; it's still far better like you proposed than it was. -- To view, visit http://gerrit.ovirt.org/33359 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97bf90264d1a1b3d8ea571daa9346d1f6b6d18d1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
