Maor Lipchuk has posted comments on this change. Change subject: core: Renamed the Method getStorageDomainIdForPoolByType ......................................................................
Patch Set 1: Code-Review+1 (2 comments) http://gerrit.ovirt.org/#/c/34030/1/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAODbFacadeImpl.java: Line 212: getCustomMapSqlParameterSource().addValue("storage_domain_id", storageDomainId)); Line 213: } Line 214: Line 215: /** Line 216: * Gets the storage domain id of the given type for the given storage pool id. Please leave the empty space as before Line 217: * @param poolId The storage pool id, Line 218: * @param type The Storage domain type. Line 219: * @return the storage domain id of the given type for the given storage pool id. Line 220: */ Line 214: Line 215: /** Line 216: * Gets the storage domain id of the given type for the given storage pool id. Line 217: * @param poolId The storage pool id, Line 218: * @param type The Storage domain type. Please replace "Storage domain" with "Storage Domain" or "storage domain" Line 219: * @return the storage domain id of the given type for the given storage pool id. Line 220: */ Line 221: private Guid getStorageDomainId(Guid poolId, StorageDomainType type) { Line 222: Guid returnValue = Guid.Empty; -- To view, visit http://gerrit.ovirt.org/34030 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifea93a14062b5d0483c8492b82444c34097ff71d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
