Daniel Erez has posted comments on this change. Change subject: core: Renamed the Method getStorageDomainIdForPoolByType ......................................................................
Patch Set 4: (3 comments) http://gerrit.ovirt.org/#/c/34030/4//COMMIT_MSG Commit Message: Line 9: The method's parameters types are clear enough, so there's no need to Line 10: include them also in the method's name. Line 11: Line 12: Change-Id: Ifea93a14062b5d0483c8492b82444c34097ff71d Line 13: Bug-Url: https://bugzilla.redhat.com/1085398 how is it related to this bz? http://gerrit.ovirt.org/#/c/34030/4/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAODbFacadeImpl.java: Line 22: public class StorageDomainDAODbFacadeImpl extends BaseDAODbFacade implements StorageDomainDAO { Line 23: Line 24: @Override Line 25: public Guid getMasterStorageDomainIdForPool(Guid pool) { Line 26: return getStorageDomainId(pool, StorageDomainType.Master); s/pool/poolId Line 27: } Line 28: Line 29: @Override Line 30: public StorageDomain getStorageDomain(Guid pool, StorageDomainType type) { Line 36: } Line 37: Line 38: @Override Line 39: public Guid getIsoStorageDomainIdForPool(Guid pool) { Line 40: return getStorageDomainId(pool, StorageDomainType.ISO); same Line 41: } Line 42: Line 43: @Override Line 44: public StorageDomain get(Guid id) { -- To view, visit http://gerrit.ovirt.org/34030 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifea93a14062b5d0483c8492b82444c34097ff71d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
