Arik Hadas has posted comments on this change. Change subject: core: dont copy old num of sockets on hotplug ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/34069/1/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java: Line 141: ( > it looks wrong.. ah, there are no brackets around !isHotsetField(srcFld.getName()) || (isHotsetField(srcFld.getName()) ... but still, we can drop the isHotsetField(srcFld.getName()) part -- To view, visit http://gerrit.ovirt.org/34069 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57bcd2287350c3146f06fe2a5c9a583c88dded04 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
