Omer Frenkel has posted comments on this change.

Change subject: core: dont copy old num of sockets on hotplug
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/34069/2/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java
File 
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java:

Line 93:     public final boolean IsFieldUpdatable(String name) {
Line 94:         return permitted.contains(name);
Line 95:     }
Line 96: 
Line 97:     public final boolean isHotsetField(String name) {
> naming - Hotset instead of HotSet
Done
Line 98:         return hotsetAllowedFields.contains(name);
Line 99:     }
Line 100: 
Line 101:     public boolean IsFieldUpdatable(Enum<?> status, String name, 
Object fieldContainer) {


-- 
To view, visit http://gerrit.ovirt.org/34069
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I57bcd2287350c3146f06fe2a5c9a583c88dded04
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to