Moti Asayag has posted comments on this change. Change subject: engine: Code needs to run once, remove from loop ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/34130/5/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetupNetworksVdsCommandParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetupNetworksVdsCommandParameters.java: Line 32: * @param removedBonds Line 33: * Removed networks only Line 34: * @param interfaces Line 35: * Interfaces that are connected to a network or bond Line 36: */ please update javadoc accordingly. Line 37: public SetupNetworksVdsCommandParameters(VDS vds, Line 38: List<Network> networks, Line 39: List<String> removedNetworks, Line 40: List<VdsNetworkInterface> bonds, -- To view, visit http://gerrit.ovirt.org/34130 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8778a6e08dc696353af95bd2be67fdb31f7f2882 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
